Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-k8s#243] Use watchers with 1m timeout #245

Merged

Conversation

Bolodya1997
Copy link

Description

Starts using watchers with 1m timeout instead of infinite watchers.

Issue link

Fixes #243.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@Bolodya1997 Bolodya1997 marked this pull request as ready for review September 23, 2021 12:04
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@denis-tingaikin denis-tingaikin merged commit 9a7e147 into networkservicemesh:main Sep 28, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nse-supplier-k8s that referenced this pull request Sep 28, 2021
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#245

Commit: 9a7e147
Author: Denis Tingaikin
Date: 2021-09-28 12:20:15 +0300
Message:
  - Merge pull request #245 from Bolodya1997/sdk-k8s#243/stop-watcher
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-k8s that referenced this pull request Sep 28, 2021
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#245

Commit: 9a7e147
Author: Denis Tingaikin
Date: 2021-09-28 12:20:15 +0300
Message:
  - Merge pull request #245 from Bolodya1997/sdk-k8s#243/stop-watcher
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Sep 28, 2021
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#245

Commit: 9a7e147
Author: Denis Tingaikin
Date: 2021-09-28 12:20:15 +0300
Message:
  - Merge pull request #245 from Bolodya1997/sdk-k8s#243/stop-watcher
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watching NSE Find leaks resources
3 participants